Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of tanh saturation in TanhSaturation component #1302

Open
aseyboldt opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1303
Open

Incorrect implementation of tanh saturation in TanhSaturation component #1302

aseyboldt opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1303
Labels
bug Something isn't working good first issue Good for newcomers MMM

Comments

@aseyboldt
Copy link

The definition of the TanhSaturation component introudces an extra scaling factor beta, ever though the transformation function contains this scaling factor already:
https://github.com/pymc-labs/pymc-marketing/blob/main/pymc_marketing/mmm/components/saturation.py#L275
@wd60622
Copy link
Contributor

wd60622 commented Dec 20, 2024

Wanna make a PR?

@wd60622 wd60622 added bug Something isn't working MMM good first issue Good for newcomers and removed Needs Triage labels Dec 20, 2024
@aseyboldt aseyboldt linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers MMM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tanh component aseyboldt/pymc-marketing
2 participants
@aseyboldt @wd60622