Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic versioning (#155) #228

Closed
wants to merge 3 commits into from
Closed

Conversation

nkoep
Copy link

@nkoep nkoep commented Aug 3, 2023

Randomly spotted this open issue and figured I'd have a go at it. Hope there are no objections to using setuptools-scm.

@lucianopaz
Copy link
Collaborator

Thanks @nkoep. I have to say that I'm strongly against setuptools-scm. I wanted to use it to get the version automatically from git tags but its main problem is that it assumes that the files you want to package are all the files that are tracked by version control. This includes:

  • .github/workflow
  • docs
  • causalpy/tests
  • All the files in the root folder like codecov, readthedocs, .gitignore, etc

In practice, setuptools-scm completely ignores the arguments of the [tool.setuptools.packages.find] section of pyproject.toml and does whatever it wants. From reading a bit of issues, this was documented back in 2017 and flagged as wont-fix because they say it's setuptools fault to opt to include all files from git. Until there is a sane solution to this problem, I will remain strongly against setuptools-scm.

@drbenvincent
Copy link
Collaborator

Definitely appreciate the effort @nkoep, but as @lucianopaz points out, setuptools-scm looks to have some problems, so I'll close this PR for now. Don't let that put you off making any other contributions if you like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants