-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy checks and jax installation in CI pipeline #6945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6945 +/- ##
=======================================
Coverage 90.69% 90.70%
=======================================
Files 100 100
Lines 16833 16845 +12
=======================================
+ Hits 15267 15279 +12
Misses 1566 1566
|
Ah nice, the mypy upgrade helps. Now it just fails because mypy has things to complain about. I'll try to fix these locally |
michaelosthege
force-pushed
the
fix-mypy
branch
from
October 10, 2023 21:22
2698e12
to
65d0501
Compare
michaelosthege
force-pushed
the
fix-mypy
branch
from
October 10, 2023 21:43
2a8ad35
to
8ddaeb9
Compare
michaelosthege
changed the title
Fix mypy pre-commit step
Fix mypy and jax installation steps in CI pipeline
Oct 10, 2023
michaelosthege
changed the title
Fix mypy and jax installation steps in CI pipeline
Fix mypy checks and jax installation in CI pipeline
Oct 10, 2023
ricardoV94
reviewed
Oct 10, 2023
5 tasks
This damn jax stuff 🤐 Going to give it its own environment yml now |
michaelosthege
force-pushed
the
fix-mypy
branch
2 times, most recently
from
October 10, 2023 22:05
5aeda21
to
4728269
Compare
michaelosthege
force-pushed
the
fix-mypy
branch
from
October 10, 2023 22:12
4728269
to
3957f16
Compare
Great, one more :D |
Thanks @michaelosthege! |
2 tasks
ricardoV94
added
the
no releasenotes
Skipped in automatic release notes generation
label
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Fixing the ❌ mypy job in our CI pipelines.
We were on an outdated
mypy==0.990
which failed to even run correctly.I upgraded to the currently latest version and proceeded to fix the errors it found.
In addition, I also fixed some more typing errors, thereby removing three files from the list of expected failures.
The jax installation was fixed by pinning jax and jaxlib to the same version 0.4.16 which is the jax version that got installed in recent CI runs (probably due to a pin in an upstream package?).
Closes #6940
Closes #6941
Checklist
Bugfixes
Maintenance
📚 Documentation preview 📚: https://pymc--6945.org.readthedocs.build/en/6945/