-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EulerMaruyama to work in v4 #6227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @junpenglao, some questions below.
Also, would it be too much trouble to split the tiny AR fixes from the new distribution refactoring into just 2 commits so that we don't have to squash everything together?
Also, would it be too much work to implement a |
Thanks for the comments.
I dont think this possible as user can input arbitrary sde_fn with moment unspecified. |
Sure: #6240 |
9b5fc40
to
fe9cb3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. We have finally achieved V3 parity xD
@junpenglao We use the default PR bullet points for the automatically generated release notes. I'll add it manually ;) |
Thanks! I mindlessly deleted everything when open the PR. |
Close #4642
Major / Breaking Changes
Bugfixes / New features
EulerMaruyama
distributionDocs / Maintenance