-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port GARCH11 to v4 #6119
Port GARCH11 to v4 #6119
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
==========================================
- Coverage 92.10% 90.66% -1.44%
==========================================
Files 86 102 +16
Lines 17844 21317 +3473
==========================================
+ Hits 16436 19328 +2892
- Misses 1408 1989 +581
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @junpenglao! Some comments/suggestions below
Co-authored-by: Ricardo Vieira <[email protected]>
Co-authored-by: Ricardo Vieira <[email protected]>
@ricardoV94 This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junpenglao this is great! Only some small typos and questions and a suggestion for the batch test.
initial_vol=2.5, | ||
) | ||
kwargs0 = init_kwargs.copy() | ||
kwargs0[arg_name] = init_kwargs[arg_name] * param_val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really clever!!!
Co-authored-by: Ricardo Vieira <[email protected]>
Thanks for the comments @ricardoV94 ! |
What is this PR about?
Porting GARCH11 to v4 (#4642)
Checklist
Major / Breaking Changes
Bugfixes
Docs / Maintenance