-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert rng_seeder
to random_seed
in 'Prior and Posterior Predictive Checks' notebook
#5896
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB ricardoV94 commented on 2022-06-14T06:08:39Z You can pass the rng directly, which is a better practice than passing a single number |
View / edit / reply to this conversation on ReviewNB ricardoV94 commented on 2022-06-14T06:08:40Z Same here |
View / edit / reply to this conversation on ReviewNB ricardoV94 commented on 2022-06-14T06:08:41Z And here.
Also can you get rid of the Constant/Mutable warning? |
View / edit / reply to this conversation on ReviewNB ricardoV94 commented on 2022-06-14T06:08:41Z Missing a random_seed here |
@ricardoV94 thanks for the comments. I believe I addressed them all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great!
Thanks @hectormz ! |
'Prior and Posterior Predictive Checks' notebook on pymc docs site has broken cell(s) because rng_seeder is no longer accepted by
Model()
#5787This PR removes
rng_seeder
and addsrng_seed
to thesample()
in the cells