Change the default init_dist in timeseries and issue UserWarning #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5829 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 74 74
Lines 13809 13816 +7
==========================================
+ Hits 12287 12293 +6
- Misses 1522 1523 +1
|
ricardoV94
force-pushed
the
timeseries_init_dist
branch
2 times, most recently
from
9149a3e to
2fd9877
Compare
twiecki
reviewed
Jun 1, 2022
twiecki
reviewed
Jun 1, 2022
ricardoV94
force-pushed
the
timeseries_init_dist
branch
from
2fd9877 to
ba7053a
Compare
ricardoV94
force-pushed
the
timeseries_init_dist
branch
from
ba7053a to
ca1a74d
Compare
…e UserWarning when not explicitly defined
ricardoV94
force-pushed
the
timeseries_init_dist
branch
from
ca1a74d to
70d04c6
Compare
ricardoV94
force-pushed
the
timeseries_init_dist
branch
from
70d04c6 to
d87e208
Compare
twiecki
approved these changes
Jun 2, 2022
|
One down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @AlexAndorra, I went ahead and opened a PR for this. Tests likely to fail for now :)
Closes #5744