Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates #5738

Merged
merged 5 commits into from
May 4, 2022
Merged

Misc updates #5738

merged 5 commits into from
May 4, 2022

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 3, 2022 •
edited
Loading

  • Remove uses of tag.ignore_logprob which is no longer recognized by Aeppl, and would result in a UserWarning
  • Retrieve RNG updates for non RandomVariables at compile time

ricardoV94
ricardoV94 commented May 3, 2022
View reviewed changes
pymc/distributions/logprob.py
tmp_rvs_to_values,
extra_rewrites=transform_opt,
use_jacobian=jacobian,
warn_missing_rvs=False,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of warning, it will fail which is a more strict behavior

@codecov
Copy link

codecov bot commented May 3, 2022 •
edited
Loading

Codecov Report

Merging #5738 (1f20998) into main (5c39f7e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5738   +/-   ##
=======================================
  Coverage   88.92%   88.93%           
=======================================
  Files          75       75           
  Lines       13734    13745   +11     
=======================================
+ Hits        12213    12224   +11     
  Misses       1521     1521
Impacted Files Coverage Δ
pymc/distributions/censored.py 94.73% <ø> (ø)
pymc/distributions/simulator.py 87.50% <ø> (-0.09%) ⬇️
pymc/aesaraf.py 91.46% <100.00%> (+0.10%) ⬆️
pymc/distributions/bound.py 100.00% <100.00%> (ø)
pymc/distributions/logprob.py 96.61% <100.00%> (+0.27%) ⬆️
pymc/distributions/mixture.py 97.02% <100.00%> (ø)
pymc/distributions/multivariate.py 92.03% <100.00%> (+<0.01%) ⬆️
pymc/distributions/timeseries.py 51.02% <100.00%> (+0.25%) ⬆️
pymc/model.py 86.55% <100.00%> (-0.08%) ⬇️

@ricardoV94 ricardoV94 mentioned this pull request May 3, 2022
Merged
@ricardoV94
Copy link
Member Author

ricardoV94 commented May 4, 2022 •
edited
Loading

This test keeps failing: test_sample_posterior_predictive_after_set_data_with_coords across PRs

@ricardoV94 ricardoV94 mentioned this pull request May 4, 2022
Closed
@ricardoV94 ricardoV94 requested a review from larryshamalama May 4, 2022 10:00
twiecki
twiecki approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed it.

@ricardoV94
Copy link
Member Author

ricardoV94 commented May 4, 2022 •
edited
Loading

Had missed one warning for the dist used in the GaussianRandomWalk

@ricardoV94 ricardoV94 merged commit a3bd083 into pymc-devs:main May 4, 2022
@ricardoV94 ricardoV94 deleted the misc_updates branch June 6, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki approved these changes

@michaelosthege michaelosthege Awaiting requested review from michaelosthege

@OriolAbril OriolAbril Awaiting requested review from OriolAbril

@larryshamalama larryshamalama Awaiting requested review from larryshamalama

Assignees
No one assigned
Labels
logprob maintenance pytensor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardoV94 @twiecki