Change tests included in arviz_compat workflow #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
change_arviz_compat_tests
branch
from
ae36027 to
ac5695e
Compare
Codecov Report
@@ Coverage Diff @@
## main #5472 +/- ##
==========================================
+ Coverage 81.39% 81.49% +0.09%
==========================================
Files 82 82
Lines 14218 14218
==========================================
+ Hits 11573 11587 +14
+ Misses 2645 2631 -14
|
Chose a set of tests that are more related to sampling + arviz, while dropping the slow test_distributions and test_distributions_random that have nothing to do with arviz
ricardoV94
force-pushed
the
change_arviz_compat_tests
branch
from
ac5695e to
d4958ae
Compare
|
Runtime is now below 25 minutes for the slowest arviz_compat workflow, down from the previous ~50 minutes. If people are happy with the included tests we can merge |
michaelosthege
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS machines in Github actions seem incredibly slow (see #5410), so I am proposing to remove the computationally heavier tests in favor of something more integration-like (which should also be more relevant for the "arviz_compat" part).
Currently this is a draft to check what the new Runtime might look like.
Chose a set of tests that are more related to sampling + arviz, while dropping the slow test_distributions and test_distributions_random that have nothing to do with arviz
Closes #5410