-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing objects and modules to docs #5439
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5439 +/- ##
==========================================
- Coverage 81.41% 81.39% -0.02%
==========================================
Files 82 82
Lines 14213 14215 +2
==========================================
- Hits 11572 11571 -1
- Misses 2641 2644 +3
|
Agree with the numpydoc standard. Its really hard to follow this library internally when docstrings are missing or not implemented. Its doubly hard when I have to search manually using an API. +100 to standardizd docstrings so we can easily compile with sphinx/napoleon |
Agree with everything you said, but this PR is not modifying docstrings nor doing anything related to numpydoc. I am only making sure all functions appear in the api section of the website. What we have currently: https://docs.pymc.io/en/latest/api.html What we'll have after merging this PR: https://pymc--5439.org.readthedocs.build/en/5439/api.html If the docstring is empty the page of that object will exist but be empty, if the docstring is badly formatted then the parameter types might not be rendered as links... we still need to fix all the docstrings (which is one of the main contributions we aim for at the sprint, see https://pymc-data-umbrella.xyz/en/latest/sprint/docstring_tutorial.html). This PR doesn't fix any docstring nor it will fix any docstring. |
@Sayam753 tried the auto documenting for math but can't really manage sphinx to not ignore the |
Is there a scripted way we can check that everything is included? maybe add it to pre-commit? |
not that I know of, especially given the complexity of pymc and submodules. I have no confidence in having gotten the public api right, especially for objects that are not imported at the top level namespace. Take shape utils for example: https://docs.pymc.io/en/latest/api/shape_utils.html. They are available as sphinx build an index called |
needed. Not only I have guessed what should be documented, what is public and what isn't
but I have also generally preserved file groupings but there might be better conceptual
groupings we could use
This means that most objects are documented at
pymc.<object>
and that therefore,as this is what we use in code, will make codeautolink work in pymc-examples, notebooks
will automatically generate links to the right api docs within the code itself.
the docstrings need to be fixed to follow numpydoc, I won't fix any docstring in this PR,
we'll tackle docstrings in the sprint.