Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nested models share coords with parents #5344

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

lucianopaz
Copy link
Contributor

Thank your for opening a PR!

Closes #5343

Depending on what your PR does, here are a few things you might want to address in the description:

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #5344 (ec18b5d) into main (b29124b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5344      +/-   ##
==========================================
+ Coverage   80.19%   80.21%   +0.02%     
==========================================
  Files          89       89              
  Lines       14845    14848       +3     
==========================================
+ Hits        11905    11911       +6     
+ Misses       2940     2937       -3     
Impacted Files Coverage Δ
pymc/model.py 84.22% <100.00%> (+0.06%) ⬆️
pymc/parallel_sampling.py 87.70% <0.00%> (+0.99%) ⬆️

@lucianopaz lucianopaz merged commit 3ab4186 into pymc-devs:main Jan 12, 2022
@lucianopaz lucianopaz deleted the nested_models branch January 12, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested models don't inherit their parent model's coords
3 participants