Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove save_trace and load_trace function #5123

Merged
merged 2 commits into from
Oct 31, 2021

Conversation

ariepratama
Copy link
Contributor

related to #5108

pymc is going to completely remove save_trace and load_trace functions. These functionalities will be replaced by arviz library.

For example save_trace should be replaced by arviz.to_netcdf (https://arviz-devs.github.io/arviz/api/generated/arviz.to_netcdf.html)

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #5123 (7c7a1a1) into main (ace2589) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5123      +/-   ##
==========================================
- Coverage   77.83%   77.61%   -0.22%     
==========================================
  Files          87       87              
  Lines       14008    13981      -27     
==========================================
- Hits        10903    10852      -51     
- Misses       3105     3129      +24     
Impacted Files Coverage Δ
pymc/backends/ndarray.py 70.30% <ø> (-16.68%) ⬇️
pymc/__init__.py 96.07% <100.00%> (ø)
pymc/backends/__init__.py 100.00% <100.00%> (ø)

@twiecki twiecki merged commit 6570f9d into pymc-devs:main Oct 31, 2021
@twiecki
Copy link
Member

twiecki commented Oct 31, 2021

Thanks @ariepratama!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants