Refactored MLDA proposal to not use trace continuation #5095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the reliance on trace continuation for the MLDA proposal, as described in #5021.
A few other updates to
mlda.py
andtest_step.py
are also included:DictToArrayBijection
that sometimes flipped the order of variables.subsample
function more compact and concise.compile_rv_inplace
in place ofaesara.function
in thedelta_logp_inverse
function.typing
to MDLA core methods and functions.value_vars
tovars
to harmonise with otherPyMC
step methods.test_step.py
.test_step.py::TestMLDA::test_variance_reduction
. This test no longer asserts whether the variance is actually reduced since this cannot be guaranteed for any seed. It only checks that the functionality is working and the correct types are returned.