Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention removal of ArviZ-delegated plotting and stats in release notes #4432

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

michaelosthege
Copy link
Member

This PR adds mentions of breaking changes that we forgot to include in the 3.11.0 release notes.

closes #4430

@michaelosthege michaelosthege changed the title Mention removal of ArviZ-delegated plotting and stats Mention removal of ArviZ-delegated plotting and stats in release notes Jan 22, 2021
RELEASE-NOTES.md Outdated
@@ -14,6 +14,7 @@ This release breaks some APIs w.r.t. `3.10.0`. It also brings some dreadfully aw
- In `sample_prior_predictive` the `vars` kwarg was removed in favor of `var_names` (see [#4327](https://github.com/pymc-devs/pymc3/pull/4327)).
- Removed `theanof.set_theano_config` because it illegally changed Theano's internal state (see [#4329](https://github.com/pymc-devs/pymc3/pull/4329)).
- We now depend on `Theano-PyMC` version `1.1.0` exactly (see [#4405](https://github.com/pymc-devs/pymc3/pull/4405)). Major refactorings were done in `Theano-PyMC` 1.1.0. If you implement custom `Op`s or interact with Theano in any way yourself, make sure to read the [Theano-PyMC 1.1.0 release notes](https://github.com/pymc-devs/Theano-PyMC/releases/tag/rel-1.1.0).
- Many plotting and diagnostic functions that were just aliasing ArviZ functions were removed (see [4397](https://github.com/pymc-devs/pymc3/pull/4397/files#)). This includes `pm.summary`, `pm.traceplot`, `pm.ess` and many more!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this as the second (or even first) point because it's probably the most important one.

@twiecki twiecki merged commit da76320 into master Jan 22, 2021
@twiecki twiecki deleted the add-missing-releasenotes branch January 22, 2021 17:42
@twiecki
Copy link
Member

twiecki commented Jan 22, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymc3: unexpected minor version effect from 3.10.0 to 3.11.0
2 participants