Only pin theano-pymc in requirements.txt #4322
Conversation
| @@ -0,0 +1,131 @@ | |||
| # BSD 3-Clause License | |||
There was a problem hiding this comment.
this is mainly taken from pandas, so my understanding is that I need to include the bsd license
Codecov Report
@@ Coverage Diff @@
## master #4322 +/- ##
==========================================
- Coverage 87.56% 87.54% -0.02%
==========================================
Files 88 88
Lines 14270 14272 +2
==========================================
Hits 12495 12495
- Misses 1775 1777 +2
|
conda-envs/environment-dev-py37.yml
Outdated
| - scipy>=0.18 | ||
| - sphinx-autobuild>=0.7 | ||
| - sphinx>=1.5 | ||
| - theano-pymc=1.0.12 |
There was a problem hiding this comment.
I thought the point is that we can drop this?
There was a problem hiding this comment.
I don't see how to drop it, I don't think it can be substituted from somewhere else. Suggestions?
So, in lieu of that, we can have a little script which checks they're all pinned to the same version
There was a problem hiding this comment.
Why not just defer to what's in requirements.txt?
There was a problem hiding this comment.
As in, leave it out of here and then do pip install -e .?
Sure, could do, but my understanding was that the recommended way of installing theano was via conda
There was a problem hiding this comment.
Just checked this again and the docs read
We only support the installation of the requirements through conda.
So, as long as we install mlk-service via conda, then we're OK to install theano-pymc via pip? If so I'll do that, it's easier than adding extra scripts/checks
MarcoGorelli
changed the title
CONTRIBUTING.md
Outdated
| @@ -15,6 +15,8 @@ We appreciate being notified of problems with the existing PyMC code. We prefer | |||
|
|
|||
| Please verify that your issue is not being currently addressed by other issues or pull requests by using the GitHub search tool to look for key words in the project issue tracker. | |||
|
|
|||
| Filter on the "beginner friendly" for issues which are good for new contributors. | |||
.pre-commit-config.yaml
Outdated
| - id: pip-to-conda | ||
| additional_dependencies: [pyyaml] | ||
| entry: python scripts/generate_pip_deps_from_conda.py | ||
| files: ^(conda-envs/environment-dev-py38\.yml|requirements-dev\.txt)$ |
There was a problem hiding this comment.
why not do this for 36 and 37 files too?
There was a problem hiding this comment.
I was originally thinking that there could be a single conda file which generates the requirements-dev file, but there's no reason why they shouldn't all generate it
Sure, done 👍
| @@ -1,4 +1,4 @@ | |||
| # This file is auto-generated from environment-dev-py38.yml, do not modify. | |||
| # This file is auto-generated from by scripts/generate_pip_deps_from_conda.py, do not modify. | |||
There was a problem hiding this comment.
| # This file is auto-generated from by scripts/generate_pip_deps_from_conda.py, do not modify. | |
| # This file is auto-generated by scripts/generate_pip_deps_from_conda.py, do not modify. |
|
Thanks! |
closes #4320