Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README #4154 #4172

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Update the README #4154 #4172

merged 2 commits into from
Oct 17, 2020

Conversation

Overlord2335
Copy link
Contributor

@Overlord2335 Overlord2335 commented Oct 17, 2020

Updated README file

  • Added PyMC discourse link in top paragragh.
  • Added Code of conduct link in Contributors section.

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes?
  • important background, or details about the implementation
  • are the changes—especially new features—covered by tests and docstrings?
  • consider adding/updating relevant example notebooks
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #4172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4172   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          89       89           
  Lines       14343    14343           
=======================================
  Hits        12747    12747           
  Misses       1596     1596           

README.rst Outdated Show resolved Hide resolved
Co-authored-by: Thomas Wiecki <[email protected]>
@twiecki twiecki merged commit 28eaf5d into pymc-devs:master Oct 17, 2020
@twiecki
Copy link
Member

twiecki commented Oct 17, 2020

Thanks @Overlord2335!

@Overlord2335
Copy link
Contributor Author

@twiecki Do I have to change anything else too as the issue is not yet closed?

@Overlord2335 Overlord2335 deleted the firt_edit branch October 18, 2020 03:46
@Overlord2335 Overlord2335 restored the firt_edit branch October 18, 2020 03:46
@twiecki
Copy link
Member

twiecki commented Oct 18, 2020

Can you link the issue?

@Overlord2335
Copy link
Contributor Author

Here is the issue, @twiecki

@AlexAndorra AlexAndorra linked an issue Oct 18, 2020 that may be closed by this pull request
@Overlord2335
Copy link
Contributor Author

@twiecki Could you point me to a open issue that I could work on as a beginner and some material to read regarding the issue too, Thanks.

@MarcoGorelli
Copy link
Contributor

Here is the issue, @twiecki

Just for the future, if you put

closes #<issue number>

in the pull request description, then that issue will be closed automatically when the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the README
3 participants