-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the README #4154 #4172
Merged
Merged
Update the README #4154 #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4172 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 89 89
Lines 14343 14343
=======================================
Hits 12747 12747
Misses 1596 1596 |
twiecki
reviewed
Oct 17, 2020
Co-authored-by: Thomas Wiecki <[email protected]>
twiecki
approved these changes
Oct 17, 2020
Thanks @Overlord2335! |
@twiecki Do I have to change anything else too as the issue is not yet closed? |
Can you link the issue? |
Closed
@twiecki Could you point me to a open issue that I could work on as a beginner and some material to read regarding the issue too, Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README file
Thank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description: