Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbqa black 5 notebooks #4165

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

MarcoGorelli
Copy link
Contributor

xref #4095

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #4165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4165   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          89       89           
  Lines       14083    14083           
=======================================
  Hits        12501    12501           
  Misses       1582     1582           

@AlexAndorra
Copy link
Contributor

Thanks @MarcoGorelli ! Actually, for this PR, let's try a new process, to limit the number of PRs that we have to open and merge: can you make only this one PR for that one issue, but with, say, one commit per 5 notebooks?
That way, I can review every commit so that it's manageable, but we can stay on this unique PR 👌

@MarcoGorelli
Copy link
Contributor Author

Hey @AlexAndorra ! I think that's a good suggestion!

We introduced a regression in nbqa 0.2.3 while trying to support pylint, and it's now fixed - my suggestion would be to take this PR as it is so that the nbqa version gets bumped. I'll then open a separate PR where I'll apply the formatter to 5 notebooks per commit and hopefully we can merge steps 2 and 3 of the style together before too long - does that sound good to you?

@AlexAndorra
Copy link
Contributor

Yeah ok, let's go with that then 👌

@AlexAndorra AlexAndorra merged commit 4fff38b into pymc-devs:master Oct 13, 2020
@MarcoGorelli MarcoGorelli deleted the black-format-notebooks branch October 13, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants