Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distribution details to GraphViz output #4159

Merged
merged 8 commits into from
Oct 8, 2020

Conversation

Spaak
Copy link
Member

@Spaak Spaak commented Oct 7, 2020

As originally discussed in #3956, since the new str functionality has now been merged into master (#4076), we can use it in GraphViz renderings.

@Spaak
Copy link
Member Author

Spaak commented Oct 8, 2020

Hmm all tests are passing locally, but failing in Travis. Will investigate.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #4159 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4159      +/-   ##
==========================================
- Coverage   88.75%   88.75%   -0.01%     
==========================================
  Files          89       89              
  Lines       14039    14038       -1     
==========================================
- Hits        12461    12460       -1     
  Misses       1578     1578              
Impacted Files Coverage Δ
pymc3/model_graph.py 88.40% <75.00%> (-0.09%) ⬇️

Copy link
Member

@ColCarroll ColCarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There was a merge conflict, I'm not sure why...

@MarcoGorelli
Copy link
Contributor

LGTM! There was a merge conflict, I'm not sure why...

black autoformatter from a different PR, probably... that issue's almost done though 😇

@twiecki twiecki merged commit f5fdebb into pymc-devs:master Oct 8, 2020
@twiecki
Copy link
Member

twiecki commented Oct 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants