Upgrade nbqa, add config options for black

[MarcoGorelli]

Ahead of #4095

[MarcoGorelli]

@AlexAndorra it seems to me that black_nbconvert doesn't respect the line length from pyproject.toml, e.g. if we have

    average_disasters[i] = np.mean(np.where(idx, trace["early_rate"], trace["late_rate"]))

(90 characters long) it'll reformat it to

    average_disasters[i] = np.mean(
        np.where(idx, trace["early_rate"], trace["late_rate"])
    )

Is that OK, or would you prefer to use the line length from pyproject.toml? (the latter is what I've gone for in this PR)

[codecov]

Codecov Report

Merging #4135 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4135   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files          89       89           
  Lines       14037    14037           
=======================================
  Hits        12458    12458           
  Misses       1579     1579           

[AlexAndorra]

Yeah it should use the line length from pyproject.toml IMO

[AlexAndorra]

LGTM, thanks @MarcoGorelli !
Does this mean people should use nbqa to blacken NBs now, instead of black_nbconvert?

[MarcoGorelli]

Does this mean people should use nbqa to blacken NBs now, instead of black_nbconvert?

If you want pyproject.toml configs to be respected, then I think that would be better - I'll update the wiki if you want this

[AlexAndorra]

Ok, let's do that then! Indeed, thanks for updating the wiki 😉
I'll wait to merge this PR, as I think you may have picked up some of these changes in #4136 -- will merge once that's cleared

[AlexAndorra]

@MarcoGorelli, since this is merged now, do you mind updating the NB style guide with the changes please?

[MarcoGorelli]

Hey @AlexAndorra - sorry for the delay, I've updated the wiki

[AlexAndorra]

Perfect, thanks a lot @MarcoGorelli !
"This step will eventually be merged in with step 2" --> exciting 😉