Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExGaussian logp #4049

Closed
wants to merge 8 commits into from
Closed

Fix ExGaussian logp #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ee52c2
Replaced 0 by epsilon in ExGaussian logp for numerical stability
AlexAndorra Aug 11, 2020
220282a
Refactored code based on Junpeng's comment
AlexAndorra Aug 12, 2020
f9930d8
Blackified continuous.py file
AlexAndorra Aug 12, 2020
0f98497
Revert back to using numpy's float type instead of pymc's
AlexAndorra Aug 12, 2020
01e5575
Use theano float type to set the espilon value
AlexAndorra Aug 12, 2020
da52490
Reorganized import statements in continuous.py
AlexAndorra Aug 12, 2020
438bc00
Merge remote-tracking branch 'upstream/master' into fix-exgaussian-logp
AlexAndorra Aug 12, 2020
56a2541
Updated release notes
AlexAndorra Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Maintenance
- Mentioned the way to do any random walk with `theano.tensor.cumsum()` in `GaussianRandomWalk` docstrings (see [#4048](https://github.com/pymc-devs/pymc3/pull/4048)).
- Fixed numerical instability in ExGaussian's logp by preventing `logpow` from returning `-inf` (see [#4049](https://github.com/pymc-devs/pymc3/pull/4049)).

### Documentation

Expand Down
Loading