Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Drop support for py3.6" #4003

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Revert "Drop support for py3.6" #4003

merged 5 commits into from
Jul 6, 2020

Conversation

junpenglao
Copy link
Member

@junpenglao junpenglao commented Jul 6, 2020

Reverts #3992 and #3998

As it
1) breaks Travis
2) preventing installing pymc3 default branch (i.e., the most up-to-date) on colab

When we are ready to drop python3.6 support:

  1. revert this PR
  2. change https://github.com/pymc-devs/pymc3/blob/1af997623afbee7c8099e20d94c7236fb5af1332/scripts/create_testenv.sh#L23
    for consistency.

@ColCarroll
Copy link
Member

Will need to re-require the dataclasses backport. Adding

dataclasses; python_version < '3.7'

to requirements.txt should do it.

@junpenglao
Copy link
Member Author

junpenglao commented Jul 6, 2020

Thanks @ColCarroll!

Also, note to future dev
When we are ready to drop python3.6 support:

  1. revert this PR
  2. change https://github.com/pymc-devs/pymc3/blob/1af997623afbee7c8099e20d94c7236fb5af1332/scripts/create_testenv.sh#L23
    for consistency.

Co-authored-by: Adrian Seyboldt <[email protected]>
@junpenglao junpenglao merged commit 77873e9 into master Jul 6, 2020
@junpenglao junpenglao deleted the revert-3992-drop-py36 branch July 6, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants