Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max_energy_error sampling stat from HMC #3783

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

eigenfoo
Copy link
Member

Something I came across while working on LittleMCMC.

Currently it looks like we define the max_energy_error dtype in HMC, but we don't seem to actually have a max_energy_error sampler stat for HMC (although I should note that NUTS does). This PR just removes the max_energy_error dtype.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #3783 into master will increase coverage by 7.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3783      +/-   ##
==========================================
+ Coverage   83.65%   90.71%   +7.05%     
==========================================
  Files         133      133              
  Lines       20328    20911     +583     
==========================================
+ Hits        17006    18970    +1964     
+ Misses       3322     1941    -1381
Impacted Files Coverage Δ
pymc3/step_methods/hmc/hmc.py 96.66% <ø> (+3.33%) ⬆️
pymc3/tests/test_ndarray_backend.py 100% <0%> (ø) ⬆️
pymc3/model.py 89.17% <0%> (+0.12%) ⬆️
pymc3/backends/ndarray.py 94.75% <0%> (+1.42%) ⬆️
pymc3/tests/helpers.py 56.6% <0%> (+1.88%) ⬆️
pymc3/sampling.py 85.05% <0%> (+1.93%) ⬆️
pymc3/distributions/shape_utils.py 100% <0%> (+11.11%) ⬆️
pymc3/memoize.py 96.15% <0%> (+13.46%) ⬆️
pymc3/variational/opvi.py 85.29% <0%> (+17.28%) ⬆️
... and 11 more

@ColCarroll ColCarroll merged commit b90de19 into master Jan 20, 2020
@ColCarroll
Copy link
Member

Thanks, @eigenfoo !

@eigenfoo eigenfoo deleted the remove-max-energy-error branch January 20, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants