Compilation error workaround #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 133 133
Lines 20328 20328
=======================================
Hits 18424 18424
Misses 1904 1904 |
ColCarroll
reviewed
Jan 13, 2020
pymc3/__init__.py
Outdated
| @@ -28,9 +36,18 @@ | |||
| from .tests import test | |||
|
|
|||
| from .data import * | |||
| import theano | |||
There was a problem hiding this comment.
This looks good to go, but I would wrap the whole thing in a mangled function, so that the top-level namespace does not get too busy.
def __set_theano_flags():
import theano
import platform
...
__set_theano_flags()
|
It doesn't feel great setting flags by default, but it seems like this is what's needed to get the project to work. A quick search shows that there were at least 3 issues in the last 4 months that this would have fixed. |
|
Given that we can't do much with Theano, its probably the best course of action. |
sthagen
added a commit
to sthagen/pymc-devs-pymc
that referenced
this pull request
Jan 15, 2020
Compilation error workaround (pymc-devs#3767)
mihaic
added a commit
to mihaic/brainiak
that referenced
this pull request
May 21, 2020
Inspired by PyMC3 workaround: pymc-devs/pymc#3767
mihaic
added a commit
to brainiak/brainiak
that referenced
this pull request
May 21, 2020
The renames do not affect the API, except for `concatenate_not_none`, where the rename actually makes the code agree to the existing documentation. The existing variable names caused errors after an update of Pycodestyle in Flake8: #464 PyCQA/pycodestyle#853 https://gitlab.com/pycqa/flake8/-/merge_requests/418 Also add a workaround for a Theano compilation error, inspired by PyMC3: pymc-devs/pymc#3767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies platform-specific flags (for Mac and Windows) to circumvent compilation errors for certain models.
Closes #3695