Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add DifferentialEquation: API for Bayesian inference of ODEs #3578
WIP: Add DifferentialEquation: API for Bayesian inference of ODEs #3578
Changes from 19 commits
e4ecd6f
5520ebf
8d9743f
5b88886
ce7dd20
58a8352
21cf56c
463bd7a
76851e2
cd140a1
8526a5b
101fe72
90f6e50
6facc4c
dca3584
70e2fd4
abc1016
5f2d63f
11e9ca5
6ecc0a5
54861b2
186f9f2
5c9ca9e
16ce3d4
bc7d480
94c79fa
977238c
24730cc
3746666
7998ebb
c1b9272
86efff3
cb2add3
de5ac44
1509507
2694a46
1cecac4
1f888a9
711287a
997ed9c
9c166ec
d5914d8
cd04ca4
84ae5c8
8ec0b38
c980b14
9777262
ce30d31
e51eaf4
d5704b7
5041c34
3ea3ffc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
ravel
destroys the shape of the prediction. It's safer to keep it 2D.(also to keep the tensor that is returned to the user 2D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. Here is the traceback when I try to rerun the notebook.
Any idea why this might be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this after you removed the ravel? There's still the reshape that should be be removable..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is after making the suggested change.
No dice. Removing the
.reshape(yobs.shape)
results in the same error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be the reason why I had
infer_shape
in the otherOp
...