Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Documentation cleanup #3575

Merged
merged 5 commits into from
Aug 1, 2019
Merged

Conversation

rpgoldman
Copy link
Contributor

I've been overwhelmed by the number of Sphinx errors and warnings. Here are changes to docstrings and configuration to get rid of a bunch of them.

Still a WIP: I'm going to add a bunch of fixes to RST files, too.

@rpgoldman rpgoldman requested a review from ColCarroll July 31, 2019 19:31
@rpgoldman rpgoldman added the docs label Jul 31, 2019
Updated to make a deprecation warning go away. This should not change the behavior at all.
Fix some minor wording errors, but mostly fixed formatting issues.
Minor typo fixes and added MultiTrace attributes section.
The `getting_started.rst` file does not yield output that is linked into the docs.  Instead, the index.rst file directly links to the pages once linked from getting_started.
@rpgoldman
Copy link
Contributor Author

@ColCarroll Please review now -- I have done as much as I can do here in the short term. If you like things you can just merge (feel free to squash merge). If not, LMK, and I will try to fix things up.

@ColCarroll ColCarroll merged commit ccf03b3 into pymc-devs:master Aug 1, 2019
@ColCarroll
Copy link
Member

Super helpful as always @rpgoldman!

Copy link
Contributor

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible job @rpgoldman!! I just left some minor suggestions on switching markdown inline code to the one used in rst's, but maybe you can ignore them if the recommonmark understands that it is dealing with markdown instead of an reStructuredText.

pymc3/distributions/timeseries.py Show resolved Hide resolved
pymc3/sampling.py Show resolved Hide resolved
@@ -205,7 +205,7 @@ def sample(draws=500, step=None, init='auto', n_init=200000, start=None, trace=N
----------
draws : int
The number of samples to draw. Defaults to 500. The number of tuned samples are discarded
by default. See discard_tuned_samples.
by default. See `discard_tuned_samples`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
by default. See `discard_tuned_samples`.
by default. See ``discard_tuned_samples``.

pymc3/sampling.py Show resolved Hide resolved
pymc3/sampling.py Show resolved Hide resolved
array-like object. For traces with more than one chain the length of each value
should match the number of total samples already in the trace (chains * iterations),
array-like objects. For traces with more than one chain the length of each value
should match the number of total samples already in the trace `(chains * iterations)`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
should match the number of total samples already in the trace `(chains * iterations)`,
should match the number of total samples already in the trace ``(chains * iterations)``,

pymc3/backends/base.py Show resolved Hide resolved
pymc3/data.py Show resolved Hide resolved
pymc3/data.py Show resolved Hide resolved
@@ -4060,7 +4060,7 @@ def logcdf(self, value):
References
----------
.. [Machler2012] Martin Mächler (2012).
"Accurately computing log(1-exp(-|a|)) Assessed by the Rmpfr
"Accurately computing :math: `\log(1-\exp(- \mid a \mid<))` Assessed by the Rmpfr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Accurately computing :math: `\log(1-\exp(- \mid a \mid<))` Assessed by the Rmpfr
"Accurately computing :math:`\log(1-\exp(- \mid a \mid<))` Assessed by the Rmpfr

@rpgoldman rpgoldman deleted the multitrace-doc branch August 1, 2019 13:31
@rpgoldman
Copy link
Contributor Author

@lucianopaz Thanks for the corrections. I will make them and push the relevant ones after testing with the documentation generator.

@rpgoldman
Copy link
Contributor Author

@lucianopaz You are right -- I didn't understand the markdown interaction. Fixing and will push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants