Remove unused powerset function. #3467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was rendered unnecessary by the revision of the _get_ancestors() method.
ColCarroll
reviewed
May 6, 2019
| @@ -35,10 +34,10 @@ def _get_ancestors(self, var, func) -> MutableSet[RV]: | |||
| """ | |||
|
|
|||
| # this contains all of the variables in the model EXCEPT var... | |||
| vars = set(self.var_list) | |||
| vars: MutableSet[RV] = set(self.var_list) | |||
There was a problem hiding this comment.
Via #3466 i think we're staying away from variable annotations for now.
There was a problem hiding this comment.
@ColCarroll Oh, OK. Sorry to hear that. I use them extensively, and find them quite helpful. May we use them in the comment form?
There was a problem hiding this comment.
Yes, their fine in comment form. But variable annotations are not supported by python 3.5 and we want to keep a tight integration with Arviz, which has to support python 3.5.
|
Hi @rpgoldman, thanks for the PR again, but I noticed this when I did #3466 earlier today so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was rendered unnecessary by the revision of the _get_ancestors() method.