Skip to content

Commit

Permalink
Add more informative comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ricardoV94 committed Jan 20, 2021
1 parent 9c5aa05 commit 723d8d4
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions pymc3/tests/test_distributions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1177,12 +1177,15 @@ def test_fun(value, mu, sigma):

self.pymc3_matches_scipy(Gamma, Rplus, {"mu": Rplusbig, "sigma": Rplusbig}, test_fun)

# pymc-devs/Theano-PyMC#224: skip_paramdomain_outside_edge_test has to be set
# True to avoid triggering a C-level assertion in the Theano GammaQ function
# in gamma.c (). Can be set back to False (defalut) once that issue is solved.
self.check_logcdf(
Gamma,
Rplus,
{"alpha": Rplusbig, "beta": Rplusbig},
lambda value, alpha, beta: sp.gamma.logcdf(value, alpha, scale=1.0 / beta),
skip_paramdomain_outside_edge_test=True, # TODO: When True, Python crashes
skip_paramdomain_outside_edge_test=True,
)

@pytest.mark.xfail(
Expand All @@ -1196,12 +1199,15 @@ def test_inverse_gamma(self):
{"alpha": Rplus, "beta": Rplus},
lambda value, alpha, beta: sp.invgamma.logpdf(value, alpha, scale=beta),
)
# pymc-devs/Theano-PyMC#224: skip_paramdomain_outside_edge_test has to be set
# True to avoid triggering a C-level assertion in the Theano GammaQ function
# in gamma.c (). Can be set back to False (defalut) once that issue is solved.
self.check_logcdf(
InverseGamma,
Rplus,
{"alpha": Rplus, "beta": Rplus},
lambda value, alpha, beta: sp.invgamma.logcdf(value, alpha, scale=beta),
skip_paramdomain_outside_edge_test=True, # TODO: When True, Python crashes
skip_paramdomain_outside_edge_test=True,
)

@pytest.mark.xfail(
Expand Down

0 comments on commit 723d8d4

Please sign in to comment.