-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 7 of Statistical Rethinking 2nd Edition #86
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
…. Awaiting clarification from @aloctavodia.
Thanks for the comments @aloctavodia. I've dealt with most of them, as well as re-done the back end of the notebook... it seems I was working from a book draft, and the final version contained quite different examples! Just awaiting clarification on your the |
OK @aloctavodia, I think I've taken care of your suggestions. Apart from the several issues that you'll probably find that need correcting, I think this is ready to merge 😄 |
LGTM, I will add a semicolon at the end of the last line of matplotlib functions to avoid the ouputs. Regarding the computation of the pairwise dse. I think we can revisit it after we decide what to do in ArviZ. |
Ah! Keep forgetting about that. Just fixed it, @aloctavodia. |
* Added Chapter 6 * First attempt at Chp_07 * Data for Chp_07 * removed chapter 6 from 7 branch * Refresh and Run All in botebook * Progress towards #86. All but pairwise WAIC calculation done. Awaiting clarification from @aloctavodia. * hacky solution to pairwise dse comparison * run black_nbconvert * clean start * First draft of Chp_08 * ran through black_nbconvert * restart and run all * Data for Chp_08 * remove unneeded data * Addressed @aloctovadia's comments (except standardised)
As promised (#67) here's a first stab at Chp_07. It turned out to be a bit more of a beast than I expected, and there are a few things that aren't quite right - any corrections/pointers appreciated. You said you might be able to help, @aloctavodia?
I've stolen quite a few bits from Chapter 6 of the 1st Edition (these are cited).
There are a few comments throughout where I hit trouble, but the main ones are:
arviz.waic
function. Mainly because I'm not sure how outputs ofarviz.waic
and rethinking'sWAIC
function are different. Neither documentation is particularly informative about what the functions actually calculate. A barrier inarviz.waic
is that settingpointwise=True
doesn't seem to return a pointwise result (returns identical if set toFalse
) as it does inWAIC
, which makes a lot of the book examples impossible. Could probably work out how to do it manually, but feels like I shouldn't have to! What have I missed?!pairwise=True
inarviz.waic
.