Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pymc3 -> pymc #165

Merged
merged 14 commits into from
Mar 23, 2022
Merged

Rename pymc3 -> pymc #165

merged 14 commits into from
Mar 23, 2022

Conversation

fonnesbeck
Copy link
Member

In advance of the PyMC4 beta, this PR is renaming pymc3 to pymc throughout, taking care to preserve cases like arviz.from_pymc3 and bcm_pymc3 which have not yet changed.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -10,7 +10,7 @@
"import matplotlib.pyplot as plt\n",
"import numpy as np\n",
"import pandas as pd\n",
"import pymc3 as pm\n",
"import pymc as pm\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I get

AttributeError: module 'pymc' has no attribute 'trace_to_dataframe'

in code 4.32

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried moving over to

trace_df = az.from_pymc3(trace=trace_4_1)

but got

ModuleNotFoundError: No module named 'pymc3'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see pr #141 is working on this

@@ -9,7 +9,7 @@
"import arviz as az\n",
"import matplotlib.pyplot as plt\n",
"import numpy as np\n",
"import pymc3 as pm\n",
"import pymc as pm\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue with this chapter using pymc too: pymc-devs/pymc#5443

canyon289 and others added 3 commits March 20, 2022 10:29
Previous commits contained the expression `Pr(positive|mortal)1 -
Pr(vampire)` as part of the normalizing constant. I believe the correct
expression is `Pr(positive|mortal)(1 - Pr(vampire))`.

This commit corrects the markdown of the vampire normalizing constant.

Co-authored-by: laj <[email protected]>
@canyon289
Copy link
Member

Should this one be merged sooner rather than later?

@twiecki
Copy link
Member

twiecki commented Mar 22, 2022

Good point, need to resolve conflicts @fonnesbeck

@fonnesbeck fonnesbeck merged commit 0f0ecf5 into pymc-devs:main Mar 23, 2022
@fonnesbeck fonnesbeck deleted the pymc_rename branch March 23, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants