Implement Maxwell Distribution #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have to implement the logp or logcdf for this one, PyMC can figure it out |
ricardoV94
reviewed
Nov 7, 2023
wd60622
commented
Nov 9, 2023
ricardoV94
approved these changes
Nov 10, 2023
|
@wd60622 We also need to revisit the Skellam for the case |
I added it to the BNB PR. I just tagged you |
|
Just need to solve the conflicts from merging the other PR |
|
Thanks @wd60622 ! |
This was referenced Nov 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the logp tests working like the other two distributions. I tried to implement the logcdf but am hitting some difficulties with those. The values are relatively close but are off by only a decimal in a few cases. I'm checking the translation from wikipedia formula and will look for some simplifications if possible. I see the scipy implements like this. If anything is obvious, let me know