-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues in pathfinder wrapper #238
Conversation
Ouch, well these all sounds like fixes to me. |
I think it is better to depends on blackjax-nightly (which would soon be release as blackjax v1), and use
per https://blackjax-devs.github.io/sampling-book/algorithms/pathfinder.html |
How soon is that soon? Would it be too much of a PITA to get another pre v1 release if that's faster? |
We just release Blackjax v1 |
2cb7f7f
to
0301d0d
Compare
Can we merge? |
I would like to have a model where this actually works as a test case, but since we are in experimental maybe that's fine. |
Needs to be rebased for tests to pass |
b86e0ff
to
c8c601d
Compare
Closes #97
Closes #250
We were doing senseless things, like drawing from an isometric MvNormal with mean two as the initial point of the VI fit and then discarding such fit? This killed my poor RAM :)
Also I am not sure what the
inference_loop
was doing. I am not familiar with the internals of blackjax (and the documentation references a version that hasn't yet been released), but I think we just want to doinit -> sample
? Can someone confirm this (@junpenglao @zaxtax?)Pathfinder doesn't seem to work particularly well with the 8 school example. It's very sensitive to the initial value of
mu
, and the default converges to something that looks wrong, see gist. Because of this I don't know what better thing to assert in the test.Also the pymc-examples is broken (it is not using mu nor tau :P): https://www.pymc.io/projects/examples/en/latest/variational_inference/pathfinder.html