Pathfinder model specification fix #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Sorry for the merge mess. Squash-merge should fix, yes? |
ricardoV94
approved these changes
Jul 18, 2024
twiecki
reviewed
Jul 18, 2024
| theta = pm.Normal("theta", mu=0, sigma=1, shape=J) | ||
| theta_1 = mu + tau * theta | ||
| z = pm.Normal("z", mu=0, sigma=1, shape=J) | ||
| theta = mu + tau * z |
twiecki
approved these changes
Jul 18, 2024
|
The model still does a terrible job of fitting a very simple model. Hopefully the GSoC project will bear some fruit. |
Yup that was why I didn't bother to push the fix. It seem to be pretty terrible, but maybe it's just a hard model still. |
|
ADVI does a fine job, and I've seen Stan's implementation fit the same
model so I'm guessing it's a problem with the Black Jax version
specifically? Could be something as simple as bad defaults, who knows?
…On Thu, Jul 18, 2024, 11:00 AM Ricardo Vieira ***@***.***> wrote:
The model still does a terrible job of fitting a very simple model.
Hopefully the GSoC project will bear some fruit.
Yup that was why I didn't bother to push the fix. It seem to be pretty
terrible, but maybe it's just a hard model still.
—
Reply to this email directly, view it on GitHub
<#674 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT4RCGF3DQ2HODASYXDJLZM7RBRAVCNFSM6AAAAABLBVZQFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZWHEZTAOJTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Re-mentioning the problem to @junpenglao @zaxtax ^ We should at least open an issue in blackjax? Pretty lame to not have it working :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deals with the easy problem in #572, the mis-specification of the model. Also added an example
num_samplesargument that may be useful for new users.📚 Documentation preview 📚: https://pymc-examples--674.org.readthedocs.build/en/674/