Handle missing libraries more robustly #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'pymc' or 'numba' or 'bridgestan' are missing imports, provide specific installation instructions. Don't rely on ImportError for missing packages, since that can be triggered downstream even when the respective package is installed. Have a single compile_X_model function for each X. Each function lazily imports X-related modules and handles missing imports.
aseyboldt
reviewed
Sep 24, 2023
python/nutpie/compile_pymc.py
Outdated
| @@ -441,7 +470,7 @@ def extract_shared(x, user_data_): | |||
| user_data = numba.carray(user_data_, (), record_dtype) | |||
|
|
|||
| _shared_tuple = shared_tuple | |||
| for index in literal_unroll(indices): | |||
| for index in numba.literal_unroll(indices): | |||
There was a problem hiding this comment.
There was a numba issue some time ago where literal_unroll only did anything if it was used without the leading numba.. I'm not sure if that is still the case, maybe we should leave it just to be sure?
There was a problem hiding this comment.
Wow, that's crazy!!!
Done.
There was a problem hiding this comment.
Ref: numba/numba#5344
|
Looks good. I'll have to remember this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'pymc' or 'numba' or 'bridgestan' are missing imports, provide specific installation instructions.
Don't rely on
ImportErrorfor missing packages, since that can be triggered downstream even when the respective package is installed.Have a single
compile_X_modelfunction for eachX. Each function lazily importsX-related modules and handles missing imports.Closes #67