[bugfix] Find files with ./ as input with a init.py file #9211

CareF · 2023-10-31T16:37:32Z

Type of Changes

	Type
✓	🐛 Bug fix

Description

When working as pylint --recursive=y ./ or pylint --recursive=y . on a directory with a __init__.py file, pylilnt will not be able to walk through other files due to an empty input for modutils.get_module_files because os.path.dirname("__init__.py") == "". This PR tries to fix this behavior.

Closes #9210

codecov · 2023-10-31T16:52:14Z

Codecov Report

Merging #9211 (d804da2) into main (b0db61e) will increase coverage by 0.01%.
Report is 17 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9211      +/-   ##
==========================================
+ Coverage   95.79%   95.81%   +0.01%     
==========================================
  Files         173      173              
  Lines       18714    18762      +48     
==========================================
+ Hits        17927    17976      +49     
+ Misses        787      786       -1

Files	Coverage Δ
pylint/lint/expand_modules.py	`95.23% <100.00%> (+0.05%)`	⬆️

... and 7 files with indirect coverage changes

for more information, see https://pre-commit.ci

CareF · 2023-12-06T07:29:45Z

Hi @Pierre-Sassoulas , anything I can do to improve this?

Pierre-Sassoulas

Sorry for not being very reactive on this one. MR that modify file discovery are really hard to review and can lead to issues with namespace package or the like so I'm very afraid to accept them 😄 This however LGTM because the only change is easy to understand os.path.dirname("__init__.py") == "" and everything else is doc or test (I did not realize that when skimming). Great MR !

tests/lint/unittest_expand_modules.py

Co-authored-by: Pierre Sassoulas <[email protected]>

DanielNoord · 2023-12-07T08:20:06Z

doc/whatsnew/fragments/9210.bugfix

+Fix bug for not being able to walk through files when work on `./` as input
+at a directory with a `__init__.py` file.


This sentence is not really understandable. I'd like to suggest something to improve but I don't even really know what it is meant to say.

Sorry I'm not English native. What I mean here is that:

It's a bug fix

The current situation is that, if there is a __init__.py file in a directory, pylint is not able to walk (iteratre through) the files in this directory

doc/whatsnew/fragments/9210.bugfix

Co-authored-by: Daniël van Noord <[email protected]>

DanielNoord

Thanks!

github-actions · 2023-12-07T12:12:27Z

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit d804da2

Pierre-Sassoulas

Than kyou for reviewing @DanielNoord ! Merging because the warning in readthedoc is unrelated and fixed on the main branch.

Co-authored-by: Pierre Sassoulas <[email protected]> Co-authored-by: Daniël van Noord <[email protected]> (cherry picked from commit abdb874)

Pierre-Sassoulas · 2023-12-07T12:46:40Z

Congratulation on becoming a pylint contributor @CareF :)

…h a __init__.py file (#9286) * [bugfix] Find files with ./ as input with a __init__.py file (#9211) Co-authored-by: Pierre Sassoulas <[email protected]> Co-authored-by: Daniël van Noord <[email protected]> (cherry picked from commit abdb874)

[bugfix] Find files with ./ as input with a __init__.py file

39a2afd

CareF and others added 3 commits November 1, 2023 01:01

Fix mypy type

201756d

[pre-commit.ci] auto fixes from pre-commit.com hooks

40e5058

for more information, see https://pre-commit.ci

fix pylint

0bb97a3

This comment has been minimized.

Sign in to view

Pierre-Sassoulas added Bug 🪲 backport maintenance/3.3.x labels Oct 31, 2023

Pierre-Sassoulas self-requested a review October 31, 2023 20:25

This comment has been minimized.

Sign in to view

Pierre-Sassoulas added this to the 3.0.3 milestone Dec 6, 2023

Pierre-Sassoulas previously approved these changes Dec 6, 2023

View reviewed changes

tests/lint/unittest_expand_modules.py Outdated Show resolved Hide resolved

Pierre-Sassoulas requested a review from DanielNoord December 6, 2023 20:46

Update tests/lint/unittest_expand_modules.py

3711492

Co-authored-by: Pierre Sassoulas <[email protected]>

CareF dismissed Pierre-Sassoulas’s stale review via 3711492 December 7, 2023 01:59

Pierre-Sassoulas previously approved these changes Dec 7, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

DanielNoord reviewed Dec 7, 2023

View reviewed changes

doc/whatsnew/fragments/9210.bugfix Outdated Show resolved Hide resolved

Update doc/whatsnew/fragments/9210.bugfix

d804da2

Co-authored-by: Daniël van Noord <[email protected]>

CareF dismissed Pierre-Sassoulas’s stale review via d804da2 December 7, 2023 11:46

DanielNoord approved these changes Dec 7, 2023

View reviewed changes

DanielNoord requested a review from Pierre-Sassoulas December 7, 2023 11:47

Pierre-Sassoulas approved these changes Dec 7, 2023

View reviewed changes

Pierre-Sassoulas merged commit abdb874 into pylint-dev:main Dec 7, 2023
43 of 44 checks passed

github-actions bot mentioned this pull request Dec 7, 2023

[Backport maintenance/3.0.x] [bugfix] Find files with ./ as input with a __init__.py file #9286

Merged

Pierre-Sassoulas added Backported and removed backport maintenance/3.3.x labels Feb 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bugfix] Find files with ./ as input with a init.py file #9211

[bugfix] Find files with ./ as input with a init.py file #9211

CareF commented Oct 31, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

CareF commented Dec 6, 2023

Pierre-Sassoulas left a comment

This comment has been minimized.

DanielNoord Dec 7, 2023

CareF Dec 7, 2023

DanielNoord left a comment

github-actions bot commented Dec 7, 2023

Pierre-Sassoulas left a comment

Pierre-Sassoulas commented Dec 7, 2023

		Fix bug for not being able to walk through files when work on `./` as input
		at a directory with a `__init__.py` file.

[bugfix] Find files with ./ as input with a __init__.py file #9211

[bugfix] Find files with ./ as input with a __init__.py file #9211

Conversation

CareF commented Oct 31, 2023 • edited Loading

Type of Changes

Description

codecov bot commented Oct 31, 2023 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

CareF commented Dec 6, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

This comment has been minimized.

DanielNoord Dec 7, 2023

Choose a reason for hiding this comment

CareF Dec 7, 2023

Choose a reason for hiding this comment

DanielNoord left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 7, 2023

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Dec 7, 2023

[bugfix] Find files with ./ as input with a init.py file #9211

[bugfix] Find files with ./ as input with a init.py file #9211

CareF commented Oct 31, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading