Fix used-before-assignment FP for generic type syntax (Py 3.12)
#9150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
False Positive π¦
jacobtylerwalls
added
the
C: used-before-assignment
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
added
the
Needs astroid update
jacobtylerwalls
added
python 3.12
and removed
Needs astroid update
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9150 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 173 173
Lines 18680 18682 +2
=======================================
+ Hits 17889 17891 +2
Misses 791 791
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 33f0dbe |
DanielNoord
approved these changes
Oct 16, 2023
Pierre-Sassoulas
approved these changes
Oct 16, 2023
|
Let's squash even if there's an astroid update and two commits so the backport is automatic ? |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
) * Fix `used-before-assignment` FP for generic type syntax (Py 3.12) * Bump astroid to 3.0.1 (cherry picked from commit cb29fbd)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Oct 16, 2023
) * Fix `used-before-assignment` FP for generic type syntax (Py 3.12) * Bump astroid to 3.0.1 (cherry picked from commit cb29fbd)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Oct 16, 2023
) (#9154) * Fix `used-before-assignment` FP for generic type syntax (Py 3.12) * Bump astroid to 3.0.1 (cherry picked from commit cb29fbd) Co-authored-by: Jacob Walls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9110