-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release branch for 2.17.5 #8887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.17.x #8887 +/- ##
===================================================
Coverage 95.57% 95.57%
===================================================
Files 178 178
Lines 18844 18844
===================================================
Hits 18010 18010
Misses 834 834
|
We won't merge this back in the main branch because 3.0 is too far away from 2.X at this point. This would break the pre-commit autoupdate, so we might do a history only merge. |
disable = ["raw-checker-failed", "bad-inline-option", "locally-disabled", "file-ignored", "suppressed-message", "useless-suppression", "deprecated-pragma", "use-symbolic-message-instead", "consider-using-augmented-assign"] | ||
disable = ["consider-using-augmented-assign"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: from where did this change arise?
When I --generate-toml-config
on 2.17.5 I get:
disable = ["raw-checker-failed", "bad-inline-option", "locally-disabled", "file-ignored", "suppressed-message", "deprecated-pragma", "consider-using-augmented-assign", "attribute-defined-outside-init", "invalid-name", "missing-module-docstring", "missing-class-docstring", "missing-function-docstring", "protected-access", "too-few-public-methods", "line-too-long", "too-many-lines", "trailing-whitespace", "missing-final-newline", "trailing-newlines", "bad-indentation", "unnecessary-semicolon", "multiple-statements", "superfluous-parens", "mixed-line-endings", "unexpected-line-ending-format", "fixme"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied tox -e docs
(probably from tbump)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. So there's a bug somewhere here, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's based on the local pylintrc ?
What's new in Pylint 2.17.5?
Release date: 2023-07-26
False Positives Fixed
Fix a false positive for
unused-variable
when there is an import in aif TYPE_CHECKING:
block andallow-global-unused-variables
is set tono
in the configuration.Closes False positive
unused-variable
forTYPE_CHECKING
imports #8696Fix false positives generated when supplying arguments as
**kwargs
to IOcalls like open().
Closes False positive
unspecified-encoding
when passing encoding as kwarg #8719Fix a false positive where pylint was ignoring method calls annotated as
NoReturn
during theinconsistent-return-statements
check.Closes False positive for
inconsistent-return-statements
with method annotated withNoReturn
return type #8747Exempt parents with only type annotations from the
invalid-enum-extension
message.
Closes False positive
invalid-enum-extension
for Enum parent class with annotations #8830Other Bug Fixes
Fixed crash when a call to
super()
was placed after an operator (e.g.not
).Closes Crash using
isinstance
+super
due to Astroid #8554Fix crash for
modified-while-iterating
checker when deletingmembers of a dict returned from a call.
Closes Crash: AttributeError: 'Call' object has no attribute 'name' #8598
Fix crash in
invalid-metaclass
check when a metaclass had duplicatebases.
Closes Crash "Fatal error while checking" with metaclass #8698
Avoid
consider-using-f-string
on modulos with brackets in template.Closes Avoid
consider-using-f-string
on modulos with brackets in template #8720.Fix a crash when
__all__
exists but cannot be inferred.Closes The undefined variable '__all__' results in an inference failed #8740
Fix crash when a variable is assigned to a class attribute of identical name.
Closes Setting the identical name between an attribute and a variable causes a fatal error #8754
Fixed a crash when calling
copy.copy()
without arguments.Closes no-argument call to copy.copy() crashes #8774
Other Changes
Fix a crash when a
nonlocal
is defined at module-level.Closes Checking incorrect usage of the keyword 'nonlocal' results in fatal errors. #8735