Minor refactor on type annotation #8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8587 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 174 174
Lines 18415 18415
=======================================
Hits 17664 17664
Misses 751 751
|
jacobtylerwalls
added
Skip news π
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 33e0cdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
A small change on #8431 to update the container (of scope nodes) type to
LocalsDictNodeNGwhich is more specific compared to the base classNodeNG.Nothing functional is changed, apologies for any inconvenience caused!