[pre-commit] Add ruff specific rules in ruff configuration #8449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Blocked π§
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8449 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 174 174
Lines 18396 18396
=======================================
Hits 17612 17612
Misses 784 784
|
DanielNoord
previously approved these changes
Mar 14, 2023
| @@ -25,7 +25,7 @@ | |||
| DeprecationDict = Dict[Tuple[int, int, int], Set[str]] | |||
|
|
|||
| OPEN_FILES_MODE = ("open", "file") | |||
| OPEN_FILES_FUNCS = OPEN_FILES_MODE + ("read_text", "write_text") | |||
| OPEN_FILES_FUNCS = (*OPEN_FILES_MODE, "read_text", "write_text") | |||
There was a problem hiding this comment.
Not sure I actually like this style, but oh well
Pierre-Sassoulas
force-pushed
the
add-ruff-rules
branch
from
6aa4e12 to
9cfb80c
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 9cfb80c |
DanielNoord
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Depends on #8448, permitted to detect astral-sh/ruff#3496