Minor refactor to util function #8243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Skip news π
Pierre-Sassoulas
approved these changes
Feb 8, 2023
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 00777c3 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8243 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 177 177
Lines 18646 18646
=======================================
Hits 17798 17798
Misses 848 848
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
(cherry picked from commit 13fbe68)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Feb 8, 2023
(cherry picked from commit 13fbe68) Co-authored-by: Zen Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Related to #8071. Small refactor to utility function
is_defined. Nothing functional is changed.Sorry @Pierre-Sassoulas. Jacob pointed out this inconsistency for the guard clauses in one of his reviews, but I misunderstood it then and did not manage correct it before merge.