Mark no-self-use as moved to extensions
#6932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Maintenance
jacobtylerwalls
added
the
Needs backport
Pull Request Test Coverage Report for Build 2486826741
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
requested changes
Jun 12, 2022
There was a problem hiding this comment.
Thank you for the quick reaction !
no-self-use was not deleted, it's moved to an extension, I think we need to separate the two cases (I plan to document deleted messages for #6670, so there will be an issue if a "deleted messages" contains extensions message that are documented elsewhere). This can't be merged with only the suggestion I made, we also need to check the use so we can merge both dict when applicable or use one or the other for other cases (we'll need to think about it for each use I think).
Co-authored-by: Pierre Sassoulas <[email protected]>
jacobtylerwalls
changed the title
no-self-use as deleted (moved to extensions)no-self-use as moved to extensions
Co-authored-by: Pierre Sassoulas <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit ab40456 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
added a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jun 15, 2022
* Mark `no-self-use` as deleted (moved to extensions) * Separate notions of deleted messages from moved messages Co-authored-by: Pierre Sassoulas <[email protected]>
Pierre-Sassoulas
added a commit
that referenced
this pull request
Jun 15, 2022
* Mark `no-self-use` as deleted (moved to extensions) * Separate notions of deleted messages from moved messages Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
See #6931 (comment)
Before
Command line:1:0: W0012: Unknown option value for '--enable', expected a valid pylint message and got 'no-self-use' (unknown-option-value)
After
Command line:1:0: R0022: Useless option value for '--enable', 'no-self-use' was moved to an optional extension, see https://pylint.pycqa.org/en/latest/whatsnew/2/2.14/summary.html#removed-checkers. (useless-option-value)