Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only emit lru-cache-decorating-method when maxsize is None #6181

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Only emit lru-cache-decorating-method when maxsize is None #6181

merged 8 commits into from
Apr 5, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #6180.

@DanielNoord DanielNoord added Bug 🪲 Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels Apr 4, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 4, 2022
@DanielNoord DanielNoord modified the milestones: 2.14.0, 2.13.5 Apr 4, 2022
@coveralls
Copy link

coveralls commented Apr 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2094472459

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 82 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 94.521%
Files with Coverage Reduction New Missed Lines %
pylint/config/arguments_manager.py 1 98.08%
pylint/config/utils.py 1 98.82%
pylint/config/argument.py 4 95.0%
pylint/checkers/classes/class_checker.py 7 94.35%
pylint/utils/utils.py 13 86.39%
pylint/lint/pylinter.py 25 95.12%
pylint/checkers/typecheck.py 31 95.22%
Totals Coverage Status
Change from base Build 2090822141: 0.02%
Covered Lines: 15698
Relevant Lines: 16608
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! 👍

pylint/message/message_definition_store.py Outdated Show resolved Hide resolved
jacobtylerwalls
jacobtylerwalls approved these changes Apr 5, 2022
View reviewed changes
pylint/message/message_definition_store.py Outdated Show resolved Hide resolved
tests/functional/l/lru_cache_decorating_method.py Outdated Show resolved Hide resolved
@DanielNoord
Copy link
Collaborator Author

Moved the rename into this PR/

jacobtylerwalls
jacobtylerwalls reviewed Apr 5, 2022
View reviewed changes
ChangeLog
@@ -80,6 +80,11 @@ Release date: TBA
Closes #6069
Closes #6136

* ``lru-cache-decorating-method`` has been renamed to ``cache-max-size-none`` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxsize is spelled as one word in the argument. What about cache-maxsize-none?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we keep it like max-size we can potentially reuse later on for another function. But I'm fine with either!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly. Happy to keep this way.

@DanielNoord DanielNoord merged commit bab3cb6 into pylint-dev:main Apr 5, 2022
@DanielNoord DanielNoord deleted the lru-cache branch April 5, 2022 14:26
@Pierre-Sassoulas Pierre-Sassoulas removed the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Apr 6, 2022
Pierre-Sassoulas added a commit that referenced this pull request Apr 6, 2022
@DanielNoord @jacobtylerwalls @Pierre-Sassoulas
Only emit lru-cache-decorating-method when maxsize is None (
0741313 
#6181)

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Pierre Sassoulas <[email protected]>
@lafrech lafrech mentioned this pull request Sep 15, 2022
Merged
@lafrech lafrech mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.13.5
Development

Successfully merging this pull request may close these issues.

pylint reports false positive error for lru_cache with maxsize omitted
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @jacobtylerwalls