Update regression tests due to improved inference in astroid #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming that this probably doesn't need a changelog entry |
nelfin
force-pushed
the
fix/astroid-926-regression-tests
branch
from
d188c98
to
a62cb39
Compare
|
(Note that these tests are XFAIL until the astroid changes land) |
cdce8p
added
the
Needs astroid update
cdce8p
requested changes
Apr 9, 2021
2 tasks
cdce8p
removed
the
Needs astroid update
cdce8p
approved these changes
May 12, 2021
cdce8p
added
the
Needs astroid update
|
@nelfin Just to be sure, it's only in draft mode because the astroid PR wasn't merged previously or do you plan to add anything else here? |
Depends astroid/pylint-dev#927. This custom logger subclass is now correctly inferred and so will raise the appropriate warnings.
Co-authored-by: Marc Mueller <[email protected]>
nelfin
force-pushed
the
fix/astroid-926-regression-tests
branch
from
264d325
to
a660f27
Compare
Yep, that's exactly the case. I left it in draft so it wasn't merged beforehand (but I suppose the failing tests should have been enough).
Fixed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Depends pylint-dev/astroid#927. This custom logger subclass is now correctly
inferred and so will raise the appropriate warnings.
Type of Changes
Related Issue
pylint-dev/astroid#926