-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isort in pre commit configuration file #2805
Add isort in pre commit configuration file #2805
Conversation
c3b3f7e
to
da9c49b
Compare
I moved a comment from the import to the top of the file in |
1 similar comment
#2806 might be blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @Pierre-Sassoulas ! Thank you for working on this. The next steps would be to have isort
in CI as well, once that's in we can merge this.
This is compatible with the current black configuration. See : psf/black#127
Change with isort triggered change with black.
Apparently black and isort do not behave the same. See : psf/black#251
Permit to verify the formatting of future commit. Following review see : pylint-dev#2805 (comment)
cf517d6
to
09913f1
Compare
Also fixed spelling in C0112 to C0116 messages following the review of pull-request pylint-dev#2036 by Ashley Whetter. See also pylint-dev#2075, pylint-dev#2077, pylint-dev#2262, pylint-dev#2654, pylint-dev#2805, pylint-dev#2809, pylint-dev#2844, pylint-dev#2992 and pylint-dev#3013 for full historical context.
Also fixed spelling in C0112 to C0116 messages following the review of pull-request pylint-dev#2036 by Ashley Whetter. See also pylint-dev#2075, pylint-dev#2077, pylint-dev#2262, pylint-dev#2654, pylint-dev#2805, pylint-dev#2809, pylint-dev#2844, pylint-dev#2992 and pylint-dev#3013 for full historical context.
Also fixed spelling in C0112 to C0116 messages following the review of pull-request pylint-dev#2036 by Ashley Whetter. See also pylint-dev#2075, pylint-dev#2077, pylint-dev#2262, pylint-dev#2654, pylint-dev#2805, pylint-dev#2809, pylint-dev#2844, pylint-dev#2992 and pylint-dev#3013 for full historical context.
Also fixed spelling in C0112 to C0116 messages following the review of pull-request pylint-dev#2036 by Ashley Whetter. See also pylint-dev#2075, pylint-dev#2077, pylint-dev#2262, pylint-dev#2654, pylint-dev#2805, pylint-dev#2809, pylint-dev#2844, pylint-dev#2992 and pylint-dev#3013 for full historical context.
Description
This add
isort
in the pre-commit configuration file and also apply it on all applicable files. Isort permit to sort import so there is less conflict during merging and rebase of file with conflicting modification. We're using a style of import compatible withblack
and made some efforts so that automated changes made byblack
are not deemed invalid and automatically reverted byisort
later in the commit hooks :It also update the version of
Black
, and of pre-commit'strailing-whitespace
andend-of-file-fixer
Type of Changes
| ✓ | 🔨 Refactoring |