[4692 regression] Test won't fail if the real click is installed

pylint-dev · Jul 21, 2021 · dbfde30 · dbfde30
1 parent 2e3778e
commit dbfde30
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tests/functional/i/inference_crash_4692.py b/tests/functional/i/inference_crash_4692.py
@@ -1,7 +1,9 @@
 """Regression test for https://github.com/PyCQA/pylint/issues/4692."""
 
-import click  # [import-error]
+# We can't use click like in the issue because the crash
+# does not appear if click is installed (astroid can analyse it)
+import notclick  # [import-error]
 
 
-for name, item in click.__dict__.items():
-    _ = isinstance(item, click.Command) and item != 'foo'
+for name, item in notclick.__dict__.items():
+    _ = isinstance(item, notclick.Command) and item != 'foo'
diff --git a/tests/functional/i/inference_crash_4692.txt b/tests/functional/i/inference_crash_4692.txt
@@ -1 +1 @@
-import-error:3:0::Unable to import 'click':HIGH
+import-error:5:0::Unable to import 'notclick':HIGH
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		import-error:3:0::Unable to import 'click':HIGH
		import-error:5:0::Unable to import 'notclick':HIGH