Update requirements #998
Update requirements #998
Conversation
| @@ -1,5 +1,6 @@ | |||
| -r requirements_test_min.txt | |||
| -r requirements_test_pre_commit.txt | |||
There was a problem hiding this comment.
I just removed that in #978 because it makes a circular import where astroid need pylint 2.8.2 that need astroid 2.5.6 and break the tests
There was a problem hiding this comment.
Interesting... The pylint requirements should be fine in theory as it allows >=2.5.6,<2.7 pylint - setup.cfg
There was a problem hiding this comment.
Found the issue: It seems to be an issue with setuptools_scm as pip install -e . would install version 0.1.dev1+... https://github.com/PyCQA/astroid/pull/998/checks?check_run_id=2659259745#step:6:97
There was a problem hiding this comment.
The fix is to remove the pre-commit requirement from requirements_test.txt I don't know if it's a circular import but I think we cannot have both the local astroid and the dependency from pylint.
There was a problem hiding this comment.
The issue isn't a circular dependency. Somehow pip install -e . will install version 0.1.dev1 of astroid which is incompatible with pylint. I think that setuptools_scm doesn't get the correct version here.
There was a problem hiding this comment.
Found the issue: pypa/setuptools-scm#414
Will look at solutions tomorrow.
cdce8p
force-pushed
the
update-requirements
branch
from
d98e7ed to
07e2282
Compare
|
@Pierre-Sassoulas It works now. The solution was to add |
|
Nice thank you. I guess we can fix pylint-dev/pylint#4505 with something similar. |
Description
Followup to #997
/CC: @Pierre-Sassoulas