Include modname in AST warnings #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 94 94
Lines 11065 11067 +2
=======================================
+ Hits 10263 10265 +2
Misses 802 802
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cdce8p
commented
Feb 9, 2024
Comment on lines
+421
to
+424
| with pytest.raises(AstroidSyntaxError, match="invalid escape sequence") as ctx: | ||
| self.builder.string_build("'\\d+\\.\\d+'") | ||
| assert isinstance(ctx.value.error, SyntaxError) | ||
| assert ctx.value.error.filename == "<unknown>" |
There was a problem hiding this comment.
Not exactly sure why the SyntaxError is raised for all Python version. Additionally this should only emit a SyntaxWarning at the moment, not a SyntaxError (which is reraised as AstroidSyntaxError).
Might be some pytest magic though..
DanielNoord
reviewed
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Python 3.12 change the DeprecationWarning for
invalid escape sequenceto aSyntaxWarning. These are now printed when the module is imported / the ast tree build. An exampleUsually it's an actual filename for warnings and not just the modname. However, it should be good enough for now.
Long term it might make sense to adjust the warnings filter for astroid to make all
SyntaxWarnings->SyntaxErrorswhich would get re-raised. Thus it would be possible to add apylint: disable(but only because the whole import isn't analyzed at all / skipped after the error).For know this will at least help debug where the warning is coming from. Users can still choose to ignore them