-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typing for Python 3.7 (1) #1555
Conversation
Pull Request Test Coverage Report for Build 2316381986
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a white line between imports and docstring whenever there originally was one.
Another approach would be to replace all
on the __future__
imports with a white lines in front of it. Black
should then remove those case where there are more than one line and we would have consitency across all files.
Rest LGTM!
@@ -310,7 +310,7 @@ mixin-class-rgx=.*Mix[Ii]n | |||
# List of members which are set dynamically and missed by pylint inference | |||
# system, and so shouldn't trigger E0201 when accessed. Python regular | |||
# expressions are accepted. | |||
generated-members=REQUEST,acl_users,aq_parent,argparse.Namespace | |||
generated-members=REQUEST,acl_users,aq_parent,argparse.Namespace,ast\.([mM]atch.*|pattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Shouldn't this be in a different PR/commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need this to fix a no-member
issue now that the string annotations are replaced with from __future__ import annotations
, see pylint-dev/pylint#6594.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! That explains it!
Added empty lines between every docstring and future import (in the changed files). There is an |
Description
Part 1 of 3 to update the typing in astroid following the bump to Python 3.7.2
Part 1: Replace
typing
aliases for builtin typesPart 2: Replace
typing
aliases forcollections.abc
classes.Part 3: Update
py-version
inpylintrc