Remove unused tryfinally builder function #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
Maintenance
|
Test on I wonder if this should be deprecated? This method won't be called in Python 3.3+ and is only called (normally) via the automatic visiting process. So I don't expect anybody on any of the supported python versions is actually using this.. |
Pierre-Sassoulas
approved these changes
Feb 8, 2022
cdce8p
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Great catch! It should indeed be safe to remove. Seems like I missed that during my refactoring 🙈 Tbh the whole Try block parsing should be fixed at some point. The separation into TryExcept and TryFinally nodes doesn't represent the current AST anymore. I'm working on a PR to make that possible (in a backwards compatible manner) at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This is no longer used I think.
Type of Changes
Related Issue