Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy warnings for astroid/rebuilder #1244

Merged
merged 7 commits into from
Nov 24, 2021
Merged

Fix mypy warnings for astroid/rebuilder #1244

merged 7 commits into from
Nov 24, 2021

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

Only 130 warnings left before we can turn on mypy.

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

@DanielNoord DanielNoord added this to the 2.9.0 milestone Nov 16, 2021
DanielNoord
DanielNoord commented Nov 16, 2021
View reviewed changes
astroid/nodes/node_classes.py Outdated Show resolved Hide resolved
astroid/rebuilder.py Outdated Show resolved Hide resolved
cdce8p
cdce8p requested changes Nov 16, 2021
View reviewed changes
astroid/nodes/node_classes.py Outdated Show resolved Hide resolved
astroid/rebuilder.py Outdated Show resolved Hide resolved
cdce8p
cdce8p reviewed Nov 17, 2021
View reviewed changes
astroid/rebuilder.py Outdated Show resolved Hide resolved
cdce8p
cdce8p reviewed Nov 17, 2021
View reviewed changes
astroid/rebuilder.py Outdated Show resolved Hide resolved
@DanielNoord DanielNoord requested a review from cdce8p November 17, 2021 10:23
DanielNoord
DanielNoord commented Nov 17, 2021
View reviewed changes
astroid/rebuilder.py Outdated Show resolved Hide resolved
cdce8p
cdce8p requested changes Nov 17, 2021
View reviewed changes
astroid/rebuilder.py Outdated Show resolved Hide resolved
astroid/rebuilder.py Outdated Show resolved Hide resolved
astroid/rebuilder.py Outdated Show resolved Hide resolved
astroid/rebuilder.py Outdated Show resolved Hide resolved
astroid/nodes/node_classes.py Outdated Show resolved Hide resolved
@cdce8p cdce8p added the pylint-tested PRs that don't cause major regressions with pylint label Nov 17, 2021
cdce8p
cdce8p approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I also tested it with Home-Assistant just to make sure since we added the asserts. As expected they everything still works.

@cdce8p cdce8p mentioned this pull request Nov 17, 2021
Open
Pierre-Sassoulas
Pierre-Sassoulas reviewed Nov 17, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the assert makes me want to wait for primers to be available in pylint. The "pylint tested" label will means a lot more then.

@cdce8p cdce8p self-assigned this Nov 22, 2021
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas primer is in place :)

@Pierre-Sassoulas
Copy link
Member

Maybe we can put it in 2.9.1 too ?

@DanielNoord
Copy link
Collaborator Author

I would thinks so! Marc already approved so I'll merge!

@DanielNoord DanielNoord modified the milestones: 2.10.0, 2.9.1 Nov 24, 2021
@DanielNoord DanielNoord merged commit 3a1cdb0 into pylint-dev:main Nov 24, 2021
@DanielNoord DanielNoord deleted the mypy-1 branch November 24, 2021 12:53
tushar-deepsource pushed a commit to tushar-deepsource/astroid that referenced this pull request Dec 20, 2021
@DanielNoord @cdce8p @tushar-deepsource
Fix mypy warnings for astroid/rebuilder (pylint-dev#1244)
6e6feec 
Co-authored-by: Marc Mueller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

@cdce8p cdce8p

Labels
pylint-tested PRs that don't cause major regressions with pylint
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @Pierre-Sassoulas @cdce8p