Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release astroid 2.8.1 #1199

Closed
2 tasks done
Pierre-Sassoulas opened this issue Oct 5, 2021 · 5 comments
Closed
2 tasks done

Release astroid 2.8.1 #1199

Pierre-Sassoulas opened this issue Oct 5, 2021 · 5 comments
Milestone
2.8.2

Comments

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Oct 5, 2021 •
edited
Loading

Tasks to do before releasing
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.8.1 milestone Oct 5, 2021
@cdce8p
Copy link
Member

cdce8p commented Oct 5, 2021

I believe the plan was to deprecate and not remove sys guard / typing guard.

@cdce8p cdce8p mentioned this issue Oct 5, 2021
Merged
4 tasks
Pierre-Sassoulas added a commit that referenced this issue Oct 6, 2021
@Pierre-Sassoulas
Deprecate is_typing_guard and is_sys_guard
c62a43b 
References #1199
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Oct 6, 2021
Merged
Pierre-Sassoulas added a commit that referenced this issue Oct 6, 2021
@Pierre-Sassoulas @cdce8p
Deprecate is_typing_guard and is_sys_guard (#1202)
395bfbd 
* Deprecate is_typing_guard and is_sys_guard

References #1199

Co-authored-by: Marc Mueller <[email protected]>
@cdce8p cdce8p reopened this Oct 6, 2021
@cdce8p
Copy link
Member

cdce8p commented Oct 6, 2021

@Pierre-Sassoulas Seems like you accidentally tagged the wrong commit for 2.8.1: 8afd6b4
Version 2.8.2.dev0 was uploaded to pypi: https://pypi.org/project/astroid/#history

https://github.com/PyCQA/astroid/runs/3819890910?check_suite_focus=true#step:6:18

--
What do you think about using 2.8.2 for the fix. That should remove any issue with the dev version.
If you want / have access, I believe you could also yank that release from pypi.

@cdce8p cdce8p mentioned this issue Oct 6, 2021
Merged
@cdce8p
Copy link
Member

cdce8p commented Oct 6, 2021

I think #1205 could be included in the release.

@Pierre-Sassoulas
Copy link
Member Author

I released 2.8.1 by tagging it 2.8.1-rc1, merged 1205 and released 2.8.2 immediately. Thank you for the quick reaction :)

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.8.1, 2.8.2 Oct 7, 2021
@cdce8p
Copy link
Member

cdce8p commented Oct 7, 2021

Thanks 🐬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.2
Development

No branches or pull requests
2 participants
@Pierre-Sassoulas @cdce8p